Pet controller success msg by WJunn987 · Pull Request #2362 · spring-projects/spring-petclinic

WJunn987 · 2026-04-19T06:01:25Z

No description provided.

Updated vet repository implementation

Update UI Text labels in vet list page

Update Owner List UI

Update the Successfull messages for PetControllerr

Signed-off-by: WJunn987 <ongweijun@1utar.my>

Update Pet Controller Add Successfull Msg

UI update

Update UI for ownerDetail

Signed-off-by: WJunn987 <ongweijun@1utar.my>

Updated Pet Controller Successfull Msg

Copilot

Pull request overview

Updates some user-facing UI strings (pet success flash messages and vet list labels), but also includes a breaking rewrite of the vet persistence layer file.

Changes:

Update PetController flash success messages for pet create/update.
Adjust fallback (non-i18n) text in the vets list template.
Replace VetRepository.java contents with controller code (introducing compilation issues and duplicate controller definitions).

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 7 comments.

File	Description
`src/main/resources/templates/vets/vetList.html`	Changes fallback text for vet list heading/columns (rendered text still comes from i18n keys).
`src/main/java/org/springframework/samples/petclinic/vet/VetRepository.java`	Replaces repository interface with a controller class (breaks compilation, duplicates existing `VetController`).
`src/main/java/org/springframework/samples/petclinic/owner/PetController.java`	Updates pet creation/update flash success messages.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-04-19T06:05:51Z

 <body>

-  <h2 th:text="#{vets}">Veterinarians</h2>
+  <h2 th:text="#{vets}">Veterinarian Directory</h2>


In Thymeleaf, th:text="#\{vets\}" replaces the element body with the value from the message bundle (messages*.properties). Since vets is defined (e.g., messages.properties:20), the new fallback text "Veterinarian Directory" will never be shown in normal operation. If the intent is to change the visible heading, update the vets message value (and translations) or use a new message key.

Suggested change

<h2 th:text="#{vets}">Veterinarian Directory</h2>

<h2 th:text="#{vets}">Vets</h2>

Copilot · 2026-04-19T06:05:51Z

+        <th th:text="#{name}">Veterinarian Name</th>
+        <th th:text="#{specialties}">Areas of Expertise</th>


These header text changes are only fallbacks; the actual rendered text comes from #{name} and #{specialties} (both defined in messages*.properties), so the page will still display the translated "Name" / "Specialties" strings. If you want the UI to read "Veterinarian Name" / "Areas of Expertise", introduce dedicated message keys (and translations) or change the existing message values (not just the fallback text).

Suggested change

<th th:text="#{name}">Veterinarian Name</th>

<th th:text="#{specialties}">Areas of Expertise</th>

<th th:text="'Veterinarian Name'">Veterinarian Name</th>

<th th:text="'Areas of Expertise'">Areas of Expertise</th>

Copilot · 2026-04-19T06:05:52Z

 		owner.addPet(pet);
 		this.owners.save(owner);
-		redirectAttributes.addFlashAttribute("message", "New Pet has been Added");
+		redirectAttributes.addFlashAttribute("message", "Pet added successfully.");


These success messages now use sentence case with trailing periods, but other controllers use title case without punctuation (e.g., OwnerController: "New Owner Created", VisitController: "Your visit has been booked"). Consider aligning the message style across controllers for consistent UI, or move these to i18n message bundles if you want more control over copy/translation.

Suggested change

redirectAttributes.addFlashAttribute("message", "Pet added successfully.");

redirectAttributes.addFlashAttribute("message", "Pet Added Successfully");

Copilot · 2026-04-19T06:05:52Z


 		updatePetDetails(owner, pet);
-		redirectAttributes.addFlashAttribute("message", "Pet details has been edited");
+		redirectAttributes.addFlashAttribute("message", "Pet details updated successfully.");


These success messages now use sentence case with trailing periods, but other controllers use title case without punctuation (e.g., OwnerController: "Owner Values Updated"). Consider aligning the message style across controllers for consistent UI, or move these to i18n message bundles if you want more control over copy/translation.

Suggested change

redirectAttributes.addFlashAttribute("message", "Pet details updated successfully.");

redirectAttributes.addFlashAttribute("message", "Pet Details Updated");

Copilot · 2026-04-19T06:05:52Z

+@Controller
+class VetController {
+
+	private static final int PAGE_SIZE = 5;
+


PR title suggests this is only about PetController success messaging, but this change set also rewrites vet UI text and replaces VetRepository with controller logic. If these vet changes are unintended, consider splitting them into a separate PR (or dropping them) to keep scope focused and reviewable.

Copilot · 2026-04-19T06:05:52Z

+@Controller
+class VetController {
+
+	private static final int PAGE_SIZE = 5;
+
+	private final VetRepository vetRepository;
+
+	public VetController(VetRepository vetRepository) {
+		this.vetRepository = vetRepository;


VetRepository.java no longer defines a VetRepository interface; it now contains a @Controller VetController class and references a VetRepository type that doesn't exist anywhere in the codebase. This will break compilation and also duplicates org.springframework.samples.petclinic.vet.VetController which already exists in VetController.java. Restore VetRepository as a Spring Data repository interface, and keep/move controller logic in VetController.java (or rename/move the controller to a correctly named file).

Copilot · 2026-04-19T06:05:53Z

 package org.springframework.samples.petclinic.vet;



The Apache 2.0 license header that is present in other source files (e.g., VetController.java, PetController.java) has been removed from this file. Please restore the standard header to keep licensing consistent across the codebase.

Signed-off-by: WJunn987 <ongweijun@1utar.my>

andrzejsydor · 2026-04-20T16:11:00Z

 			RedirectAttributes redirectAttributes) {
 		if (result.hasErrors()) {
-			redirectAttributes.addFlashAttribute("error", "There was an error in updating the owner.");
+			redirectAttributes.addFlashAttribute("error", "Error updating the owner.");


why it's better the the old one?

andrzejsydor · 2026-04-20T16:11:13Z

    </tr>
    <tr>
-      <th th:text="#{address}">Address</th>
+      <th th:text="#{address}">Owner's Address</th>


You're inside Owner table, and there is a label

Pet Owners Directory
not need to be Owner prefix in the columns.

andrzejsydor · 2026-04-20T16:11:16Z

    </tr>
    <tr>
-      <th th:text="#{city}">City</th>
+      <th th:text="#{city}">Owner's City</th>


You're inside Owner table, and there is a label

Pet Owners Directory
not need to be Owner prefix in the columns.

andrzejsydor · 2026-04-20T16:11:20Z

    </tr>
    <tr>
-      <th th:text="#{telephone}">Telephone</th>
+      <th th:text="#{telephone}">Owner's Telephone</th>


You're inside Owner table, and there is a label

Pet Owners Directory
not need to be Owner prefix in the columns.

andrzejsydor · 2026-04-20T16:11:26Z

      <tr>
-        <th th:text="#{name}" style="width: 150px;">Name</th>
-        <th th:text="#{address}" style="width: 200px;">Address</th>
+        <th th:text="#{name}" style="width: 150px;">Owner Name</th>


You're inside Owner table, and there is a label

Pet Owners Directory
not need to be Owner prefix in the columns.

andrzejsydor

added comments

ky7721 and others added 27 commits April 17, 2026 16:02

Update OwnerController.java

708288e

Change UI color

da1f7a4

Change UI color

19c5f46

Add Welcome text

13db3ee

Change message

deca6f1

Update OwnerController.java

70b427c

Updated vet repository implementation

b774500

Merge pull request #1 from BigRen0606/feature/request-validation

d8c55de

Updated vet repository implementation

Update UI Text labels in vet list page

94fc35a

Merge pull request #3 from ky7721/feature/ui-text-update

2c83887

Update UI Text labels in vet list page

Update Owner List UI

a0fa874

Update the Successfull messages for PetController

b38e86a

Merge pull request #4 from ky7721/feature/owner-list-update

b8af30f

Update Owner List UI

Merge pull request #5 from ky7721/WJChanges

2ce65df

Update the Successfull messages for PetControllerr

Add CI pipeline using Github Actions

6ae9627

Update Pet Controller Add Successfull Msg

efd7941

Fix VetRepository class definition

6fbd3da

Merge branch 'main' into PetControllerUpdate

967aae1

Signed-off-by: WJunn987 <ongweijun@1utar.my>

Merge pull request #6 from ky7721/PetControllerUpdate

448eb19

Update Pet Controller Add Successfull Msg

Change UI color

9be2311

Merge pull request #7 from ky7721/UIUpdate

993eb5f

UI update

Updated Pet Controller Successfull Msg

39a503d

Update UI for ownerDetail

685c828

Merge pull request #8 from ky7721/feature/owner-details-ui

1b84c1c

Update UI for ownerDetail

Merge branch 'main' into PetControllerMsgUpdate

392c2b3

Signed-off-by: WJunn987 <ongweijun@1utar.my>

Merge pull request #9 from ky7721/PetControllerMsgUpdate

6cb6757

Updated Pet Controller Successfull Msg

Updated PetController Success Msg

4fef434

Copilot AI review requested due to automatic review settings April 19, 2026 06:01

Copilot started reviewing on behalf of WJunn987 April 19, 2026 06:01 View session

Copilot AI reviewed Apr 19, 2026

View reviewed changes

Merge branch 'main' into PetControllerSuccessMsg

bce820f

Signed-off-by: WJunn987 <ongweijun@1utar.my>

andrzejsydor reviewed Apr 20, 2026

View reviewed changes

andrzejsydor suggested changes Apr 20, 2026

View reviewed changes

	<h2 th:text="#{vets}">Veterinarian Directory</h2>
	<h2 th:text="#{vets}">Vets</h2>

		<th th:text="#{name}">Veterinarian Name</th>
		<th th:text="#{specialties}">Areas of Expertise</th>

	redirectAttributes.addFlashAttribute("message", "Pet added successfully.");
	redirectAttributes.addFlashAttribute("message", "Pet Added Successfully");

Conversation

WJunn987 commented Apr 19, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Apr 19, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 19, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 19, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 19, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 19, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 19, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 19, 2026

Choose a reason for hiding this comment

Uh oh!

andrzejsydor Apr 20, 2026

Choose a reason for hiding this comment

Uh oh!

andrzejsydor Apr 20, 2026

Choose a reason for hiding this comment

Pet Owners Directory

Uh oh!

andrzejsydor Apr 20, 2026

Choose a reason for hiding this comment

Pet Owners Directory

Uh oh!

andrzejsydor Apr 20, 2026

Choose a reason for hiding this comment

Pet Owners Directory

Uh oh!

andrzejsydor Apr 20, 2026

Choose a reason for hiding this comment

Pet Owners Directory

Uh oh!

andrzejsydor left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants